-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/테스크 리뉴얼, 이의신청 인증 수정 #78
The head ref may contain hidden characters: "feat/\uC6B4\uB3D9-\uC778\uC99D-\uD398\uC774\uC9C0"
Feat/테스크 리뉴얼, 이의신청 인증 수정 #78
Conversation
dest: 'public', | ||
disable: process.env.NEXT_PUBLIC_MODE === 'development', | ||
skipWaiting: true, | ||
workboxOptions: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 미완인 이미지캐싱관련 부분인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다! 주간 발표 이후에 이미지 캐싱 관련 자료를 찾아보진 않았지만, 해당 파일에서 이미지 캐싱 코드를 더 추가할 예정입니다
@@ -47,6 +48,7 @@ | |||
"@types/react-dom": "^18", | |||
"eslint": "^8", | |||
"eslint-config-next": "14.2.3", | |||
"msw": "^2.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msw는 무슨 목적인가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스크 페이지에서 백엔드에 요청을 보내니 백엔드 쪽에서 워크스페이스가 종료되고 이의신청이 없어야 요청을 보낼 수 있다해서 mocking을 msw로 하려고 의존성을 설치했지만, 그냥 로컬에 json 형태로 목업을 넣어서 테스트 했습니다!
name: string; | ||
contributeScore: number; | ||
rank: number; | ||
height: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height이라는 값이 저의 생각에는 number를 나타내는 것 같은데 모두 string 값이더라구요 사용되는 곳에서도 높이를 설정하기 위한 css용도이고요. 어떻게 생각하시나요? 의견이 궁금합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전 number을 단독으로 사용하지 않고, className에 'h-10'과 같이 'h-'와 같이 사용되기 때문에 숫자도 string으로 줬습니다. 약간의 통일성(?)을 위해 string으로 타입을 통일했습니다!
className='w-10 h-10 rounded-full' | ||
placeholder='blur' | ||
blurDataURL='image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQGAhKmMIQAAAABJRU5ErkJggg==' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blurDataURL이건 뭔가용?
이 값들은 뭔가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지를 로드할 때 이미지의 뷰 포인트에 도달하기 전까지 블러 처리가 되도록 'blur' 옵션을 넣었습니다. 그리고 blurDataURL은 회색을 나타내는 코드입니다!
📝작업 내용