feat: 28기 신입모집 최신화 #127
Merged
feat: 28기 신입모집 최신화 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 28기 신입모집에 맞게 날짜 변경
9/2 09:00 ~ 9/15 223:59:59
2yunseong
commented
Aug 29, 2024
src/constants/recruit/faq.ko.ts
Outdated
There was a problem hiding this comment.
@LJH098 @gyuminzzz @rlajm1203
이 파일이 faq반영 내용입니다. 혹시 다른 내용이 있다면 제보 바랍니다.
Comment on lines
+15
to
+18
| { TEXT: "서류 접수 시작", DATE: "9/2" }, | ||
| { TEXT: "서류 접수 마감", DATE: "9/15" }, | ||
| { TEXT: "면접 진행", DATE: "9/23 ~ 9/25" }, | ||
| { TEXT: "최종 합격 안내", DATE: "9/30" }, |
There was a problem hiding this comment.
@LJH098 @gyuminzzz @rlajm1203
시간 확인 부탁드립니다.
Comment on lines
+11
to
+12
| START_DATE: Date.UTC(2024, 8, 2, 9, 0, 0), | ||
| END_DATE: Date.UTC(2024, 8, 15, 23, 59, 59), |
There was a problem hiding this comment.
해당 시간 맞는지 체크바랍니다.
@LJH098 @gyuminzzz @rlajm1203
- 2024.09.02 09:00
- 2024.09.15 23:59:59
Comment on lines
+13
to
+26
| if ( | ||
| recruitStartDate.getTime() - now > 0 && | ||
| recruitEndDate.getTime() - now > 0 | ||
| ) { | ||
| setRecruitStatus("READY"); | ||
| } else if ( | ||
| recruitStartDate.getTime() - now <= 0 && | ||
| recruitEndDate.getTime() - now > 0 | ||
| ) { | ||
| setRecruitStatus("OPEN"); | ||
| } else { | ||
| setRecruitStatus("CLOSED"); | ||
| } | ||
| }, 1000); |
There was a problem hiding this comment.
@loopy-lim 시간 검증 혹시 ~ 틀렸다면 말씀해주세요
There was a problem hiding this comment.
시간 검증은 올바른 것 같습니다.!!
cleanup작업까지 하셔서 side effect또한 보이지 않습니다!!
loopy-lim
approved these changes
Aug 29, 2024
Comment on lines
+13
to
+26
| if ( | ||
| recruitStartDate.getTime() - now > 0 && | ||
| recruitEndDate.getTime() - now > 0 | ||
| ) { | ||
| setRecruitStatus("READY"); | ||
| } else if ( | ||
| recruitStartDate.getTime() - now <= 0 && | ||
| recruitEndDate.getTime() - now > 0 | ||
| ) { | ||
| setRecruitStatus("OPEN"); | ||
| } else { | ||
| setRecruitStatus("CLOSED"); | ||
| } | ||
| }, 1000); |
There was a problem hiding this comment.
시간 검증은 올바른 것 같습니다.!!
cleanup작업까지 하셔서 side effect또한 보이지 않습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
주요 변경사항
IS_ON상태를 폐지시켰습니다. 그 이유는 md에 정리해두었습니다.START_DATE와END_DATE를 속성으로 받아오게 하였습니다.IS_ON이 deprecated 됨에 따라 새로운 상태,recruitStatus를 만들었습니다. 이는useRecruitStatus를 통해 접근 가능합니다.useRecruitStatus는 현재시간과START_DATE,END_DATE에 따라 현재 Recruit의 상태를 1초 마다 가져오는 훅입니다.이 외 구현사항은 아래 스크린 샷을 참고해주세요.
스크린 샷
OPEN 상태에서의
/recruitCLOSED 상태에서의
/recruitREADY 상태에서의
/recruitmain 페이지 변경 (참고)
white에서text-netural-300으로 변경되었습니다.READY 상태에서의 main 페이지
OPEN 상태에서의 main 페이지
CLOSED 상태에서의 main 페이지