PMTiles: invert y axis of tile coordinates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The y axis of XYZ tiles is oriented from north to south. When enumerating tiles for a given bounding box, the y coordinates have to be enumerated from north/top to south/bottom.
hfs
force-pushed
the
pmtiles-tile-coordinates
branch
from
e715b14 to
d13d61f
Compare
|
That could definitely be the case. I'll have to write a test for it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tsmock,
this is a small follow-up request to 4af7ac2. I think there’s a small logical error when calculating the XYZ tiles to download given the current viewport bounding box.
If the bounding box happens to span at least two rows of tiles, the generated list of tiles to download from
TileXYZ.tilesFromBBox()is empty.The y axis of XYZ tiles is oriented from north to south. When enumerating tiles for a given bounding box, the y coordinates have to be enumerated from north/top to south/bottom. Top/bottom have to be switched in the function.