Added tooltips to library properties window #13045
Conversation
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @@ -69,6 +73,15 @@ public void initialize() { | |||
| userSpecificFileDirectoryValidationVisualizer.setDecoration(new IconValidationDecorator()); | |||
| laTexFileDirectoryValidationVisualizer.setDecoration(new IconValidationDecorator()); | |||
|
|
|||
| String userString = preferences.getFilePreferences().getUserAndHost().replace("-" + OS.getHostName(), ""); | |||
| userSpecificFileDirectoryTooltip.setText("User: " + userString + ", Host: " + OS.getHostName()); | |||
There was a problem hiding this comment.
The tooltip text should be localized using Localization.lang to support multilingual capabilities, as per JabRef's localization guidelines.
There was a problem hiding this comment.
| laTexFileDirectoryTooltip.textProperty().bind( | ||
| viewModel.laTexFileDirectoryProperty().map(path -> | ||
| "Directory for LaTeX files: " + (path.isEmpty() ? "(not set)" : path) | ||
| ) |
There was a problem hiding this comment.
The tooltip text should be localized using Localization.lang to support multilingual capabilities, as per JabRef's localization guidelines.
There was a problem hiding this comment.
There was a problem hiding this comment.
Solution too dirty.
Start with rewriting
org.jabref.logic.preferences.JabRefCliPreferences#getUserAndHost
to
private UserAndHost getUserAndHost() {
and UserAndHost as new Class maybe with StringProperty / or a final string as the hostname cannot be changed AFAIK
Similar to other preferences
Adapt all other methods and settings accordingly.
# Conflicts: # jabgui/src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java # jabgui/src/main/resources/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml
|
Apologies for the numerous commit messages - I tried merging with upstream and it seems to have added all those previous commits. |
| @@ -0,0 +1,23 @@ | |||
| package org.jabref.logic.util; | |||
|
|
|||
| public class UserAndHost { | |||
There was a problem hiding this comment.
This is a typical record in Java, isn't it?
| <JabRefIconView fx:id="libSpecificFileDirSwitchIcon" glyph="ABSOLUTE_PATH"/> | ||
| </graphic> | ||
| <tooltip> | ||
| <Tooltip fx:id ="libSpecificFileDirSwitchTooltip" text="%Switch to absolute path: converts the path to an absolute path."/> |
There was a problem hiding this comment.
seems like your. merge was not proper
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
|
Closing this PR due to inactivity 💤 Please reopen the PR when you continue working on this |
Closes #12269
Added tooltips for the library properties window:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)