Fix wnnm with ref clip and update NOISY preset #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a 16 bit clip to wnnm with a ref clip, it will currently throw a FormatsRefClipMismatchError as it compares the 16 bit input clip to the converted 32 bit ref. I fixed that by having it compare the 32 bit work clip to the ref.
As for the NOISY preset, a block_size of 16 and overlap of 8 can lead to more desirable results and it doesn't make sense to use the same values from the FAST preset.
Finally, I adjusted the nlmeans strength in the example readme as the value is way too high for the default wmode.