Fix TRT selection in dpir #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cuda is None` check is useless because `cuda` is always defined by line 73 after the 0b3a105 refactor (this is caught by mypy). So what actually ends up happening is that the TRT backend is always chosen if it's supported by the current system, even if the user explicitly wants another backend. Before: dpir(clip) # backend = Backend.TRT dpir(clip, cuda=False) # backend = Backend.TRT dpir(clip, cuda=True) # backend = Backend.TRT dpir(clip, cuda="trt") # backend = Backend.TRT After: dpir(clip) # backend = Backend.TRT dpir(clip, cuda=False) # backend = Backend.NCNN_VK dpir(clip, cuda=True) # backend = Backend.ORT_CUDA dpir(clip, cuda="trt") # backend = Backend.TRT
There is no step with an ID of "dependencies" so the mypy step was never running. We could add the ID to the "Install dependencies" step but that's really not necessary when the job will fail early at that step anyways if it doesn't succeed. Since reintroducing mypy here will probably produce a bunch of errors I'm sticking `continue-on-error: true` on it for now.
|
Bruh |
Setsugennoao
merged commit 48ae3af
into
Jaded-Encoding-Thaumaturgy:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cuda is Nonecheck is useless becausecudais always defined by line 73 after the 0b3a105 refactor (this is caught by mypy). So what actually ends up happening is that the TRT backend is always chosen if it's supported by the current system, even if the user explicitly wants another backend.Before:
After: