-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build_project and use builtin lua in neovim #127
Conversation
Reviewer's Guide by SourceryThis pull request removes the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JafarAbdi - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good overall, but we noticed that the
rust
andcpp
runners from the originalbuild_project.py
script are not present in the new Lua configuration. Is there a plan to add these back, or are they no longer needed?
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
581f15a
to
7bef982
Compare
Summary by Sourcery
Remove the 'build_project.py' script and integrate file execution directly into Neovim using Lua. Add snippet support and enhance installation scripts to support macOS. Update plugin lock file with new commits.
New Features:
Enhancements:
Chores: