Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin completion #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Builtin completion #130

wants to merge 1 commit into from

Conversation

JafarAbdi
Copy link
Owner

@JafarAbdi JafarAbdi commented Sep 7, 2024

The only issue now is, snippet is being expanded always

from dataclasses import dataclass

Will expand dataclass to dataclass(_cls)

Summary by Sourcery

Implement a built-in completion feature in Neovim, enhance Docker container setup in Fish shell, and clean up unused configurations and dependencies.

New Features:

  • Introduce a new built-in completion feature in Neovim configuration that triggers LSP completion or falls back to a default behavior when no LSP client is available.

Enhancements:

  • Improve the setup_container function in the Fish shell configuration to include copying the GitHub Copilot configuration to Docker containers if it doesn't already exist.
  • Enhance the install-repgrep function to support both Darwin and Linux operating systems by dynamically selecting the appropriate binary.

Chores:

  • Remove unused functions and configurations from the Fish shell configuration, including findreplace, findreplacehidden, and restart-zerotier-one.
  • Clean up Neovim configuration by removing deprecated nvim-cmp setup and related capabilities.

Copy link
Contributor

sourcery-ai bot commented Sep 7, 2024

Reviewer's Guide by Sourcery

This pull request implements built-in completion functionality, removes the nvim-cmp plugin, and makes various other changes to the Neovim configuration and Fish shell scripts. The changes focus on improving the completion experience and updating installation scripts.

File-Level Changes

Change Details Files
Implement built-in completion functionality in Neovim
  • Add InsertCharPre autocmd to trigger completion
  • Enable LSP completion on LspAttach
  • Set up keybindings for completion and signature help
  • Remove nvim-cmp plugin and its configuration
neovim/.config/nvim/init.lua
neovim/.config/nvim/lazy-lock.json
Update Fish shell configuration and installation scripts
  • Remove findreplace and findreplacehidden functions
  • Remove restart-zerotier-one function
  • Update install-repgrep function to support both Darwin and Linux
  • Add installation of pixi and repgrep to install-dev-core function
fish/config.fish
fish/conf.d/installs.fish
Modify Docker container setup in Fish configuration
  • Add copying of github-copilot configuration to container setup
fish/config.fish

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@JafarAbdi JafarAbdi force-pushed the feature/builtin_cmp branch from 048542e to 024577d Compare October 18, 2024 22:10
@JafarAbdi
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant