forked from MeltanoLabs/tap-snowflake
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/merge meltanolabs #4
Open
OBakalash
wants to merge
13
commits into
JamieSplitit:main
Choose a base branch
from
OBakalash:dev/merge_meltanolabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for native batch-based sync (MeltanoLabs#13) * add devcontainer config * feat: table profiling and incremental sync for batch * Update tap_snowflake/client.py Co-authored-by: Edgar R. M. <[email protected]> * seemingly working incremental with batch support * linting * more linting --------- Co-authored-by: Edgar R. M. <[email protected]> Co-authored-by: Ken Payne <[email protected]>
Co-authored-by: Ken Payne <[email protected]>
* support python 3.11 * update dependencies for 3.11 * update sdk
Co-authored-by: Edgar R. M. <[email protected]>
The next release of the SDK adds support for SQLAlchemy 2.0 but this tap does not support it yet. In fact, `snowflake-sqlalchemy` has this same constraint: https://github.com/snowflakedb/snowflake-sqlalchemy/blob/de68d864af14200643b74625db4480db87c92172/setup.cfg#L50
…eltanoLabs#34) For more context look at this bug thread: meltano/sdk#1831 Co-authored-by: Nidhi Kakulawaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.