Add support for new languages #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NextFire
requested changes
Jan 14, 2024
NextFire
requested changes
Jan 14, 2024
notebook/yohane.ipynb
Outdated
| @@ -179,7 +179,7 @@ | |||
| "\n", | |||
| "yohane = Yohane(vocals_extractor)\n", | |||
| "yohane.load_song(Path(song_filename))\n", | |||
| "yohane.load_lyrics(lyrics_area.value)\n", | |||
| "yohane.load_lyrics(lyrics_area.value, language=\"jp\")\n", | |||
|
|
||
| @dataclass | ||
| class _Text: | ||
| raw: str | ||
|
|
||
| language: str |
There was a problem hiding this comment.
Suggested change
| language: str | |
| language: str | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added a new optional argument to set the language of the lyrics whihc relies on the pyphen library. The change comes with a new attribute in the Text class that specifies the language. the attribute is only used in the
Wordclass so I'm not very sure about the implementation.