[WIP] use gulp-umd instead of browserify-shim #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe rollup-stream is a better alternative: https://github.com/gulpjs/gulp/blob/master/docs/recipes/rollup-with-rollup-stream.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles created using browserify-shim do not work in AMD enviroments. https://github.com/eduardolundgren/gulp-umd creates proper UMD wrappers and should be able solve problems like JedWatson/react-select#270.
I don't have much experience with browserify/gulp/node, but this is what I've come up with.
However, when trying the changes on react-select, I end up with an empty dist file.