R2DBC Testing #2430
Open
R2DBC Testing #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Feb 26, 2025
| @@ -1,4 +1,4 @@ | |||
| package org.jetbrains.exposed.sql.tests.demo | |||
| package org.jetbrains.exposed.sql.exposed.r2dbc.tests.demo | |||
| @@ -292,6 +292,7 @@ suspend fun <Key : Any, T : IdTable<Key>> T.insertIgnoreAndGetId( | |||
| ): EntityID<Key>? { | |||
| val stmt = StatementBuilder { insertIgnore(body) } | |||
| return InsertExecutable<Long, InsertStatement<Long>>(stmt).run { | |||
| // TODO TransactionManager.current() fails here | |||
There was a problem hiding this comment.
could you tell me if changes from @bog-walk branch will fix it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since this PR is not into the
r2dbc-poc-2but intofix-metadatabranch it's not supposed to be merged, and more for questions and review.I tried to adopt some tests from
exposed-teststoexposed-r2dbc-tests, and faced several issues:exposed-r2dbchas access to the r2dbc transaction manager, and the code from the core module still tries to get thread local transaction, and fails for r2dbc?