Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Cocoapods to Swift Package Dependencies #415

Merged

Conversation

paulplant
Copy link
Collaborator

  • Cocoapod framework installation will no longer be needed. Packages will be automatically downloaded by Xcode.

  • if this commit is pulled into a previous build folder, the Pod folder, Podfile and also Podfile.lock files can be safely deleted from the folder.

  • @JohanDegraeve - once merged, Podfile and Podfile.lock should be deleted from the repository as they will be no longer needed

image

@paulplant paulplant force-pushed the swift-package-dependencies branch from c8ad820 to 043f535 Compare January 15, 2023 19:38
@paulplant paulplant force-pushed the swift-package-dependencies branch from 043f535 to 9cdf228 Compare January 16, 2023 21:42
@LiroyvH
Copy link
Contributor

LiroyvH commented Jan 16, 2023

I have just cloned this branch and installed it on top of my existing xDrip4iO5 that was installed using the Pods. No problems, it compiled immediately, installed fine and so far everything seems to be working OK. Nice. :)

@bjornoleh
Copy link
Contributor

I have also built in top of previous local clone wih pods, no issues. Additionally, I have built using GitHub Actions / Fastlane by adapting #412 (without any pod related commits), and this also worked perfectly. This proves that it builds also on a fresh build environment, as the MacOS for Fastlan builds is "single use".

@JohanDegraeve JohanDegraeve merged commit a46bd45 into JohanDegraeve:develop Jan 28, 2023
@paulplant paulplant deleted the swift-package-dependencies branch February 2, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants