Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the GitHub runner clock with the Windows time server #477

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

bjornoleh
Copy link
Contributor

Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

name: Sync clock
run: sudo sntp -sS time.windows.com
Added to the following workflows / jobs:

validate_secrets.yml / validate-fastlane-secrets
add_identifiers.yml / identifiers
build_xdrip.yml / build
create_certs.yml / certificates

Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

name: Sync clock
run: sudo sntp -sS time.windows.com
Added to the following workflows / jobs:

validate_secrets.yml / validate-fastlane-secrets
add_identifiers.yml / identifiers
build_xdrip.yml / build
create_certs.yml / certificates
@bjornoleh
Copy link
Contributor Author

This workaround is also being applied to iAPS and LoopFollow. It fixes a vast amount of build errors due to GitHub runner issues with the machine time it is booted with. Syncing to the Windows time server fixes the issue. There is an ongoing effort to fix things on the GitHub end, see the mentioned issue report at the runner repository. We don't know how soon this might be fixed. For LF and iAPS, we decided its not worth waiting, since the fix is trivial and harmless.

@paulplant
@JohanDegraeve

@paulplant
Copy link
Collaborator

paulplant commented Dec 3, 2023

@JohanDegraeve - I think this can be merged directly (and then pushed to master) without waiting for any of the other changes that are waiting for dev. All changed files are external to the actual project code so no merge conflict risk. No version changes are needed.

@bjornoleh

This comment was marked as outdated.

@paulplant
Copy link
Collaborator

Thanks, but everything must first be merged into dev... you can close the new one that goes directly to master 🙏

@bjornoleh
Copy link
Contributor Author

Thanks, but everything must first be merged into dev... you can close the new one that goes directly to master 🙏

Thanks, yes I saw the branch protection rule popping up 😅

@JohanDegraeve JohanDegraeve merged commit fba5c4e into JohanDegraeve:develop Dec 3, 2023
@bjornoleh bjornoleh deleted the sync_clock branch December 3, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants