Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launcher to work on M1 macs with modern JDK/JVM version #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wvdschel
Copy link

@wvdschel wvdschel commented May 2, 2022

I had some trouble running Apps generated with this repository on an M1 Mac running macOS 12.3.1.

Because of the bundled JavaAppLauncher binary lacking any source code, I was unable to investigate whether this was because of the ARM processor, the newer OS, or the newer Java version.

I've replaced the binary with a bash script that works on my machine. I've tested this with the Java version provided by the Adoptium/Temurin project (version: OpenJDK18U-jdk_aarch64_mac_hotspot_18_36.pkg).

I've tested it with both bundling the JVM and using the system JVM, as well as the older AdoptOpenJDK 8 version.

I'm unable to test this on x86 Macs, or older versions of the OS, as I don't have access to any of those.

@wvdschel wvdschel mentioned this pull request May 2, 2022
@jakebathman
Copy link

Hey from the future on an M3 MBP. Thanks for this update, it works great for my simple personal use of wanting an app binary for a java thing (in my case, Chatty, the twitch chat client).

Sad the jar2app is abandoned, but that's how open source goes. Appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants