Fix launcher to work on M1 macs with modern JDK/JVM version #55
+3
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble running Apps generated with this repository on an M1 Mac running macOS 12.3.1.
Because of the bundled
JavaAppLauncher
binary lacking any source code, I was unable to investigate whether this was because of the ARM processor, the newer OS, or the newer Java version.I've replaced the binary with a bash script that works on my machine. I've tested this with the Java version provided by the Adoptium/Temurin project (version:
OpenJDK18U-jdk_aarch64_mac_hotspot_18_36.pkg
).I've tested it with both bundling the JVM and using the system JVM, as well as the older AdoptOpenJDK 8 version.
I'm unable to test this on x86 Macs, or older versions of the OS, as I don't have access to any of those.