Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug in adding iterations #129

Merged
merged 2 commits into from
May 31, 2021
Merged

Resolve bug in adding iterations #129

merged 2 commits into from
May 31, 2021

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented May 31, 2021

Resolves #128

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #129 (5c7a652) into dev (a5e4448) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #129   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files          11       11           
  Lines         575      575           
=======================================
  Hits          498      498           
  Misses         77       77           
Impacted Files Coverage Δ
src/tuned_models.jl 91.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e4448...5c7a652. Read the comment docs.

@ablaom
Copy link
Member Author

ablaom commented May 31, 2021

Failure of CI for Julia 1.0 is a known issue tracked here and orthogonal to this important bug fix - so merging anyhow.

@ablaom ablaom merged commit da9364b into dev May 31, 2021
@ablaom ablaom mentioned this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incrementing n by 1 is adding 2 models to history
2 participants