Skip to content

Fix #166 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #166 #168

wants to merge 3 commits into from

Conversation

dlfivefifty
Copy link

@dlfivefifty dlfivefifty commented Dec 5, 2024 •
edited
Loading

Avoids StackOverflow in promote_type

@dlfivefifty dlfivefifty mentioned this pull request Dec 5, 2024
Open
@blegat
Copy link
Member

blegat commented Dec 5, 2024

I'd rather have it fix at MultivariatePolynomials level so if JuliaAlgebra/MultivariatePolynomials.jl#307 works I'd go for that one

@dlfivefifty
Copy link
Author

You need both: this avoids an ambiguity that would be introduced in JuliaAlgebra/MultivariatePolynomials.jl#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlfivefifty @blegat