Implement functional styled markup interpreter #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a monolithic ~600 line macro, we create a submodule "StyledMarkup" and extract all of the inner functions of the macro into top-level function of the submodule, creating a State type along the way. In my eyes, this is equivalent in terms of code organisation, but should allow for a "functional" form of the styled"" macro with minimal changes.
tecosaur
force-pushed
the
functional-styled-markup
branch
from
e10e5bb to
e17130b
Compare
Now that we have reorganised the styled"" macro, we can take a shot at implementing a functional variant of the macro. This allows for annotation markup in plain strings (e.g. sourced from a user), to be converted into styled AnnotatedStrings without the use of `eval`, opening up new use cases.
tecosaur
force-pushed
the
functional-styled-markup
branch
from
e17130b to
10f6839
Compare
|
If there are no objections/concerns raised, I intend to merge this early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
styled("{markup...}")as a complement tostyled"{markup...}". In my opinion, this is a rather valuable addition, unlocking new use cases (such as the ability to handle untrusted markup without@eval), making StyledStrings more easily fuzz-able, and improving the modularity/design of the codebase.