Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Add option to make verbose = true apply recursively to nested test sets #3

Closed
wants to merge 1 commit into from

Conversation

mhauru
Copy link

@mhauru mhauru commented Jan 17, 2025

I wanted a feature where verbose = true would apply to nested test sets all the way down the nesting, so I made it. Any interest in having this as part of DefaultTestSet? I didn't discuss this with anyone before hand, so "we don't want this, please close" is a valid response.

I wasn't sure about the best interface. I went with verbose = 2, but happy to consider e.g. verbose = :recursive. Currently verbose = 1 is equivalent to verbose = true.

I'm leaving this as a draft because it currently breaks the DefaultTestSet constructors: If someone uses the "full" inner constructor with a Bool for verbose it'll error. DefaultTestSet isn't exported, but I would still like to fix that. I'll pause here to get comments though before implementing the fix.

@mhauru
Copy link
Author

mhauru commented Jan 17, 2025

Wrong repo, see JuliaLang/julia#57084 instead.

@mhauru mhauru closed this Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant