-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent footer regression in blog #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first pull request to this repo! The Julia Programming Language's website is community driven and relies on updates from folks like you. Welcome and thanks again.
And since I have you guys here: I have a few nitpicks/typos/mistakes for juliacomputing.com site. Where should I report there? Couldn't find a repo. |
I don't think it is faulty, it is meant to be there. I agree it looks somewhat strange though. Perhaps it should have a "About the author" header or something to clarify. |
That is not what I am talking about. The dark-blue website footer gets compressed to the wrong width. |
Oh, I see. But then the "about the author" stuff should be fixed rather than removed I think. |
Yeah sure, makes sense. Also, I have a few nitpicks/typos/mistakes for juliacomputing.com site. Where should I report them? Couldn't find a repo. |
I don't know, don't they have some contact adress on their website? |
Yeah, I was just making sure if someone more "in the know" knew a more
appropriate place or repo. Sorry if I wasted a bit of your time.
|
It looks like in an effort to implement an "about the author" footer for this issue #1009 in this PR 8949145, the introduced per-post footer messed with the site-wide footer.
There are the only affected pages, because these are the only ones using
{{about_the_author}}
Note: I barely know anything about CSS or documenter, so just decided to delete the footers until someone fixes it.
Faulty footer:
![Screenshot from 2021-04-19 13-29-30](https://user-images.githubusercontent.com/17922991/115278410-696af580-a113-11eb-89fd-624344e8dae2.png)
![Screenshot from 2021-04-19 13-31-13](https://user-images.githubusercontent.com/17922991/115278525-8c95a500-a113-11eb-843f-6b16d4e9e929.png)
Normal footer: