Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent footer regression in blog #1277

Closed
wants to merge 1 commit into from
Closed

Fix inconsistent footer regression in blog #1277

wants to merge 1 commit into from

Conversation

Omar-Elrefaei
Copy link
Contributor

It looks like in an effort to implement an "about the author" footer for this issue #1009 in this PR 8949145, the introduced per-post footer messed with the site-wide footer.

There are the only affected pages, because these are the only ones using {{about_the_author}}

Note: I barely know anything about CSS or documenter, so just decided to delete the footers until someone fixes it.

Faulty footer:
Screenshot from 2021-04-19 13-29-30
Normal footer:
Screenshot from 2021-04-19 13-31-13

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first pull request to this repo! The Julia Programming Language's website is community driven and relies on updates from folks like you. Welcome and thanks again.

@Omar-Elrefaei Omar-Elrefaei changed the title Fix inconsistent footer regression Fix inconsistent footer regression in blog Apr 19, 2021
@Omar-Elrefaei
Copy link
Contributor Author

And since I have you guys here: I have a few nitpicks/typos/mistakes for juliacomputing.com site. Where should I report there? Couldn't find a repo.

@fredrikekre
Copy link
Member

I don't think it is faulty, it is meant to be there. I agree it looks somewhat strange though. Perhaps it should have a "About the author" header or something to clarify.

@Omar-Elrefaei
Copy link
Contributor Author

That is not what I am talking about. The dark-blue website footer gets compressed to the wrong width.
Go to that end of these two posts to compare.

@fredrikekre
Copy link
Member

Oh, I see. But then the "about the author" stuff should be fixed rather than removed I think.

@fredrikekre
Copy link
Member

#1278

@Omar-Elrefaei
Copy link
Contributor Author

Omar-Elrefaei commented Apr 19, 2021

Yeah sure, makes sense.


Also, I have a few nitpicks/typos/mistakes for juliacomputing.com site. Where should I report them? Couldn't find a repo.
??

@fredrikekre
Copy link
Member

I don't know, don't they have some contact adress on their website?

@Omar-Elrefaei
Copy link
Contributor Author

Omar-Elrefaei commented Apr 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants