Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #109.
Our arbitrary-precision eigensolver works by Newton's method on$\det(J - \lambda I)$ where $J$ is the Jacobi matrix, but the problem is that the determinant calculation easily underflows. However, since what we actually want is only the ratio $\det(J - \lambda I) / \det'(J - \lambda I)$ (the Newton step), we can rescale to this ratio at each step of the tridiagonal-determinant iteration to suppress under/ovrerflow.
On a separate note, the Newton iteration was missing the
break
statement on the convergence check, so it was taking 1000x longer than necessary!