Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup gauss for symmetric rules #113

Merged
merged 1 commit into from
Jul 27, 2024
Merged

speedup gauss for symmetric rules #113

merged 1 commit into from
Jul 27, 2024

Conversation

stevengj
Copy link
Member

For symmetric rules (corresponding to a HollowSymTridiagonal Jacobi matrix), we can speed up gauss by only doing Newton refinement and eigenvector calculation for half of the points, since the other half are the mirror image.

This gives a 2x speedup for BigFloat gauss rules, where these steps dominate. It doesn't seem to make much difference for Float64 gauss rules, which are probably dominated by the LAPACK eigvals call.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (62eabae) to head (be4e746).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   98.55%   98.43%   -0.13%     
==========================================
  Files           7        7              
  Lines         694      703       +9     
==========================================
+ Hits          684      692       +8     
- Misses         10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj stevengj merged commit 9b1acdb into master Jul 27, 2024
9 of 10 checks passed
@stevengj stevengj deleted the gauss_sym_speedup branch July 27, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant