Skip to content

Switch Requires.jl to weakdep, and require Julia 1.10+ (thus dropping support for Julia 1.6 through 1.9) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

julia> @time using Quadmath
  0.009195 seconds (8.15 k allocations: 549.961 KiB, 34.84% compilation time) # before
  0.006442 seconds (4.01 k allocations: 305.828 KiB) #after

@oscardssmith oscardssmith requested a review from DilumAluthge May 5, 2025 17:21
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Windows CI is failing?

SpecialFunctions = "2.0"
Test = "<0.0.1, 1"
julia = "1.6"
julia = "1.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change (dropping support for Julia 1.6 through 1.9) intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes (but I can make this work on older versions if desired)

@DilumAluthge DilumAluthge changed the title Switch Requires.jl to weakdep Switch Requires.jl to weakdep, and require Julia 1.10+ (thus dropping support for Julia 1.6 through 1.9) May 7, 2025
@DilumAluthge
Copy link
Member

Actually, I don't even think we need to drop support for Julia 1.6 through 1.9. Instead, we can do the following:

  1. On Julia versions 1.6 through 1.9, make SpecialFunctions a regular direct dep.
  2. On Julia 1.10+, make SpecialFunctions a weakdep.

Basically, following the instructions in the "Transition from normal dependency to extension" section here: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension

@DilumAluthge
Copy link
Member

And then, since we aren't dropping support for any old Julia versions, we can just do the patch version bump of 0.5.13 ---> 0.5.14.

@DilumAluthge
Copy link
Member

Either way, we do need to fix Windows CI on this PR.

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants