-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming throughput monitor #494
Draft
jpsamaroo
wants to merge
16
commits into
jps/stream2
Choose a base branch
from
df/stream-throughput-monitor
base: jps/stream2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return_type() is kinda broken in v1.10, see: JuliaLang/julia#52385 In any case Base.promote_op() is the official public API for this operation so we should use it anyway.
Reference Dagger.EAGER_THUNK_STREAMS explicitly
This always us to handle all the other kinds of task specs.
Special-case StreamingFunction in EagerThunkMetadata() constructor
Co-authored-by: Julian Samaroo <[email protected]>
jpsamaroo
force-pushed
the
jps/stream2
branch
2 times, most recently
from
April 5, 2024 21:52
0f747ed
to
fa01410
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
June 24, 2024 20:03
1c4473b
to
21217ab
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
2 times, most recently
from
August 3, 2024 16:57
ed89a7f
to
3274093
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
August 18, 2024 22:46
3274093
to
4013384
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
October 12, 2024 18:48
9f0ac3f
to
96bad48
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
November 16, 2024 19:48
96bad48
to
b3b70e1
Compare
jpsamaroo
force-pushed
the
jps/stream2
branch
from
November 26, 2024 21:17
245d06a
to
e772af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In collaboration with @davidizzle.
Implements a throughput monitor for streaming tasks, which monitors a pipeline and prints throughput estimates periodically.
Todo:
ctr