-
Notifications
You must be signed in to change notification settings - Fork 15
Introduction of R2N Solver in JSOSolvers #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
farhadrclass
wants to merge
14
commits into
JuliaSmoothOptimizers:main
Choose a base branch
from
Farhad-phd:PR2N
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to check the obj once it has been accepted
fix the restart issue Update R2N.jl Update callback.jl Allocate test
tmigot
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @farhadrclass for the PR. A first batch of comments.
The tests fail because of extra allocations. Any idea why?
What are the differences with FOMO?
dpo
requested changes
Feb 6, 2025
dpo
reviewed
Feb 6, 2025
dpo
reviewed
Feb 6, 2025
dpo
reviewed
Feb 6, 2025
dpo
reviewed
Feb 6, 2025
dpo
reviewed
Feb 8, 2025
fixed the bug Test edge cases, and make the reviews Update R2N.jl R2N Edge cases Update test_edge_cases.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the new R2N solver, a first-order quadratic regularization method for unconstrained optimization, along with the implementation of a shifted system solver function. These contributions provide robust and efficient tools for solving challenging optimization tasks.
Key Additions
Usage Example
Parameters
nlp::AbstractNLPModel{T, V}
: The model to solve, as defined inNLPModels.jl
.x::V = nlp.meta.x0
: Initial guess.atol::T = √ε(T)
: Absolute tolerance.rtol::T = √ε(T)
: Relative tolerance, where the algorithm stops when ‖∇f(xᵏ)‖ ≤ atol + rtol * ‖∇f(x⁰)‖.η1 = ε(T)^(1/4)
,η2 = T(0.95)
: Step acceptance parameters.γ1 = T(1/2)
,γ2 = 1/γ1
: Regularization update parameters.σmin = ε(T)
: Step parameter.max_eval::Int = -1
: Maximum number of objective function evaluations.max_time::Float64 = 30.0
: Maximum time limit in seconds.max_iter::Int = typemax(Int)
: Maximum number of iterations.β = T(0) ∈ [0,1]
: Momentum term constant. No momentum ifβ == 0
.verbose::Int = 0
: Display iteration details everyverbose
iteration.subsolver_type::Union{Type{<:KrylovSolver}, Type{ShiftedLBFGSSolver}} = ShiftedLBFGSSolver
: Subsolver for the shifted system, defaulting toShiftedLBFGSSolver
.subsolver_verbose::Int = 0
: Displays iteration information for the subsolver whensubsolver_verbose > 0
.