Wrap _runtests_in_current_env in current logger to avoid world age …

…issues (#46)

* Wrap `_runtests_in_current_env` in current logger

* Bump patch version

Project.toml

@@ -1,6 +1,6 @@
 name = "ReTestItems"
 uuid = "817f1d60-ba6b-4fd5-9520-3cf149f6a823"
-version = "1.3.0"
+version = "1.3.1"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

src/ReTestItems.jl

@@ -205,15 +205,19 @@ function _runtests(shouldrun, paths, nworkers::Int, nworker_threads::Int, worker
     proj_file = identify_project(dir)
     proj_file == "" && error("Could not find project directory for `$(dir)`")
     @debugv 1 "Running tests in `$paths` for project at `$proj_file`"
-    if is_running_test_runtests_jl(proj_file)
-        # Assume this is `Pkg.test`, so test env already active.
-        @debugv 2 "Running in current environment `$(Base.active_project())`"
-        return _runtests_in_current_env(shouldrun, paths, proj_file, nworkers, nworker_threads, worker_init_expr, testitem_timeout, retries, verbose_results, debug, report, logs)
-    else
-        @debugv 1 "Activating test environment for `$proj_file`"
-        return Pkg.activate(proj_file) do
-            TestEnv.activate() do
-                _runtests_in_current_env(shouldrun, paths, proj_file, nworkers, nworker_threads, worker_init_expr, testitem_timeout, retries, verbose_results, debug, report, logs)
+    # Wrapping with the logger that was set before eval'ing any user code to
+    # avoid world age issues when logging https://github.com/JuliaLang/julia/issues/33865
+    with_logger(current_logger()) do
+        if is_running_test_runtests_jl(proj_file)
+            # Assume this is `Pkg.test`, so test env already active.
+            @debugv 2 "Running in current environment `$(Base.active_project())`"
+            return _runtests_in_current_env(shouldrun, paths, proj_file, nworkers, nworker_threads, worker_init_expr, testitem_timeout, retries, verbose_results, debug, report, logs)
+        else
+            @debugv 1 "Activating test environment for `$proj_file`"
+            return Pkg.activate(proj_file) do
+                TestEnv.activate() do
+                    _runtests_in_current_env(shouldrun, paths, proj_file, nworkers, nworker_threads, worker_init_expr, testitem_timeout, retries, verbose_results, debug, report, logs)
+                end
             end
         end
     end