Avoid duplicate log printing (#50)

* Avoid duplicate log printing

* Add a test

src/ReTestItems.jl

@@ -385,9 +385,14 @@ function start_and_manage_worker(
                 # back up to the main coordinator task and throw to the user
                 rethrow()
             end
-            println(DEFAULT_STDOUT[])
-            # Explicitly show captured logs or say there weren't any
-            _print_captured_logs(DEFAULT_STDOUT[], testitem, nretries + 1)
+
+            if !(e isa TestSetFailure)
+                println(DEFAULT_STDOUT[])
+                # Explicitly show captured logs or say there weren't any in case we're about
+                # to terminte the worker
+                _print_captured_logs(DEFAULT_STDOUT[], testitem, nretries + 1)
+            end
+
             if e isa TimeoutException
                 @debugv 1 "Test item $(repr(testitem.name)) timed out. Terminating worker $worker"
                 terminate!(worker)

test/integrationtests.jl

@@ -657,4 +657,15 @@ end
     end
 end
 
+# https://github.com/JuliaTesting/ReTestItems.jl/issues/49
+@testset "Worker log capture on a failing test is not reported twice" begin
+    test_file_path = joinpath(TEST_FILES_DIR, "_failing_test.jl")
+
+    captured = IOCapture.capture(rethrow=Union{}) do
+        encased_testset(()->runtests(test_file_path, nworkers=1, logs=:issues))
+    end
+
+    @test count("No Captured Logs", captured.output) == 1
+end
+
 end # integrationtests.jl testset

test/junit_xml.jl

@@ -19,7 +19,7 @@ function remove_variables(str)
         r" time=\\\"[0-9]*.[0-9]*\\\"" => " time=\"0\"",
         # Replace tag `value` in a <property> with "0"
         # e.g. "<property name=\"dd_tags[perf.gctime]\" value=\"1.23e-6\"></property>"
-        r" value=\"[\d]*[.]?[\d]*?[e]?[-]?[\d]?\"(?=></property>)" => " value=\"0\"",
+        r" value=\"[-]?[\d]*[.]?[\d]*?[e]?[-]?[\d]?\"(?=></property>)" => " value=\"0\"",
         # Omit stacktrace info between "Stacktrace" and the line containing "</error>".
         # Stacktraces are version specific.
         r" Stacktrace:[\s\S]*(?=\n\s*</error)" => " Stacktrace:\n [omitted]",

test/testfiles/_failing_test.jl

@@ -0,0 +1,3 @@
+@testitem "A single test item that fails" begin
+    @test false
+end