Skip to content

Commit

Permalink
Merge pull request #48 from lassehastrup/users/lha/addedSecuritySetti…
Browse files Browse the repository at this point in the history
…ngsRuleSet

Updated ruleSet to include security settings for 'SubscriptionNotRegistered'
  • Loading branch information
JulianHayward authored Nov 1, 2024
2 parents 6826d07 + ce9e76e commit 16d0c1c
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 6 deletions.
Binary file modified pwsh/module/build/AzAPICall.zip
Binary file not shown.
2 changes: 1 addition & 1 deletion pwsh/module/build/AzAPICall/AzAPICall.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
RootModule = 'AzAPICall.psm1'

# Version number of this module.
ModuleVersion = '1.2.3'
ModuleVersion = '1.2.4'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down
5 changes: 3 additions & 2 deletions pwsh/module/build/AzAPICall/functions/AzAPICallFunctions.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ function AzAPICallErrorHandler {
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/pricings*" } { $getARMMDfC = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/securescores*" } { $getARMMdFC = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/securityContacts*" } { $getARMMdFCSecurityContacts = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/settings*" } { $getARMMdFCSecuritySettings = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)*/federatedIdentityCredentials*" } { $getARMManagedIdentityUserAssignedFederatedIdentityCredentials = $true }
#MicrosoftGraph
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].MicrosoftGraph)/v1.0/applications*" } { $getMicrosoftGraphApplication = $true }
Expand Down Expand Up @@ -1341,7 +1342,7 @@ function AzAPICallErrorHandler {
}
}

elseif (($getARMMDfC -or $getARMMdFCSecurityContacts) -and $catchResult.error.code -eq 'Subscription Not Registered') {
elseif (($getARMMDfC -or $getARMMdFCSecurityContacts -or $getARMMdFCSecuritySettings) -and $catchResult.error.code -eq 'Subscription Not Registered') {
Logging -preventWriteOutput $true -logMessage "$defaultErrorInfo - AzAPICall: skipping Subscription - return 'SubscriptionNotRegistered'"
$response = @{
action = 'return' #break or return or returnCollection
Expand Down Expand Up @@ -1723,7 +1724,7 @@ function getAzAPICallFunctions {
function getAzAPICallRuleSet {
return $function:AzAPICallErrorHandler.ToString()
}
function getAzAPICallVersion { return '1.2.3' }
function getAzAPICallVersion { return '1.2.4' }

function getJWTDetails {
<#
Expand Down
2 changes: 1 addition & 1 deletion pwsh/module/dev/AzAPICall/AzAPICall.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
RootModule = 'AzAPICall.psm1'

# Version number of this module.
ModuleVersion = '1.2.3'
ModuleVersion = '1.2.4'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down
3 changes: 2 additions & 1 deletion pwsh/module/dev/AzAPICall/functions/AzAPICallRuleSet.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function AzAPICallErrorHandler {
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/pricings*" } { $getARMMDfC = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/securescores*" } { $getARMMdFC = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/securityContacts*" } { $getARMMdFCSecurityContacts = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)/subscriptions/*/providers/Microsoft.Security/settings*" } { $getARMMdFCSecuritySettings = $true }
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].ARM)*/federatedIdentityCredentials*" } { $getARMManagedIdentityUserAssignedFederatedIdentityCredentials = $true }
#MicrosoftGraph
{ $_ -like "$($AzApiCallConfiguration['azAPIEndpointUrls'].MicrosoftGraph)/v1.0/applications*" } { $getMicrosoftGraphApplication = $true }
Expand Down Expand Up @@ -635,7 +636,7 @@ function AzAPICallErrorHandler {
}
}

elseif (($getARMMDfC -or $getARMMdFCSecurityContacts) -and $catchResult.error.code -eq 'Subscription Not Registered') {
elseif (($getARMMDfC -or $getARMMdFCSecurityContacts -or $getARMMdFCSecuritySettings) -and $catchResult.error.code -eq 'Subscription Not Registered') {
Logging -preventWriteOutput $true -logMessage "$defaultErrorInfo - AzAPICall: skipping Subscription - return 'SubscriptionNotRegistered'"
$response = @{
action = 'return' #break or return or returnCollection
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
function getAzAPICallVersion { return '1.2.3' }
function getAzAPICallVersion { return '1.2.4' }

0 comments on commit 16d0c1c

Please sign in to comment.