Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST_MAXFILESIZE should be usable together with USESAFEDOCKER #358

Open
ifrh opened this issue Dec 22, 2022 · 1 comment
Open

TEST_MAXFILESIZE should be usable together with USESAFEDOCKER #358

ifrh opened this issue Dec 22, 2022 · 1 comment

Comments

@ifrh
Copy link
Contributor

ifrh commented Dec 22, 2022

In README.md it is mentioned:

The maximum size of a file produced by a user submission (setting TEST_MAXFILESIZE, currently not supported with USESAFEDOCKER, until http://stackoverflow.com/questions/25789425 is resolved)

In http://stackoverflow.com/questions/25789425, which has been posted in Nov 2014, there exists an answer from the year 2015 with a pointer to moby/moby#4717 which has been closed. ( cf. moby/moby#4717 (comment) )

@ifrh
Copy link
Contributor Author

ifrh commented Dec 31, 2022

seems to be implementet in PR #354

https://github.com/KITPraktomatTeam/Praktomat/pull/354/files#diff-990f53fe06b9e396f4b76a0a746410e78d99eb7653a07c887a3f529b0381f0a6R91-R93

after merging that PR only removing from README.md the lines is needed:

 * The maximum size of a file produced by a user submission (setting
   `TEST_MAXFILESIZE`, currently not supported with `USESAFEDOCKER`, until
http://stackoverflow.com/questions/25789425 is resolved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant