Bugfix small typos in src/settings/* #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 23, 2017 11:07
…ITPraktomatTeam#260 Signed-off-by: Robert Hartmann (FB02, H-BRS) <[email protected]>
…olutionfiles and not only allow to download them
src/settings/defaults.py src/settings/devel.py src/settings/local.py src/settings/test.py Signed-off-by: Robert Hartmann (FB02, H-BRS) <[email protected]>
This was referenced Mar 1, 2017
Closed
added 3 commits
March 3, 2017 12:27
Signed-off-by: Robert Hartmann (FB02, H-BRS) <[email protected]>
Signed-off-by: Robert Hartmann (FB02, H-BRS) <[email protected]>
Signed-off-by: Robert Hartmann (FB02, H-BRS) <[email protected]>
src/settings/defaults.py
Outdated
| @@ -313,8 +328,8 @@ def __setattr__(self,k,v): | |||
|
|
|||
| # Length of timeout applied whenever an external check that runs a students | |||
| # submission is executed, | |||
| # for example: JUnitChecker, DejaGnuChecker | |||
| d.TEST_TIMEOUT=60 | |||
| # for example: JUnitChecker, DejaGnuChecker | |||
There was a problem hiding this comment.
@physikerwelt : You worte in May 2017 "ws change?" ... the change was just adding a python comment after d.TEST_TIMEOUT=60 to mention, that all shell scripts have to use "ulimit -t 60" so that they can stop on their own.
There was a problem hiding this comment.
ws= whitespace. Plese delete the trailing whitespace in line 343
physikerwelt
suggested changes
May 11, 2017
src/settings/defaults.py
Outdated
| # insulation. Should not be used together iwth USEPRAKTOMATTESTER. | ||
| # insulation. Should not be used together with USEPRAKTOMATTESTER. | ||
|
|
||
| # It is recomendet to use DOCKER and not a tester account |
There was a problem hiding this comment.
@physikerwelt (just recognised your comment from may 2017.) What do you mean with "d" ?
"recomendet" => "recomended" or what else?
If you see an error like **There was a problem confirming the ssl certificate** or **tlsv1 alert protocol version or TLSV1_ALERT_PROTOCOL_VERSION**, you need to be connecting to PyPI with a newer TLS support library. PyPI turned off support for TLS versions 1.0 and 1.1 in April 2018
…itmodules_https-proxy_compatible
…itmodules_https-proxy_compatible
…rainerTutor_Watch_SolutionFiles
closes CVE-2018-14574: Open redirect possibility in CommonMiddleware
…ownload_solutiondetails
…ort_tasklist_via_names
# Conflicts: # requirements.txt
…ithub.com/ifrh/Praktomat into feature_gitmodules_https-proxy_compatible # Conflicts: # .gitlab-ci.yml
added 2 commits
February 25, 2019 21:47
…jango_1-11-15' Update requirements.txt use Django 1.11.19 See merge request rhartm2m/praktomat_hbrs!21
Add download link to Template solution_detail.html See merge request rhartm2m/praktomat_hbrs!25
Bugfix small typos in src/settings/* See merge request rhartm2m/praktomat_hbrs!26
Update "master32" from "KITPraktomatTeam/master" (add Mime-Type for *.lean files)
Use trigger testing and coverage for python 2.7 and multiple python 3.x versions.
show output of "conda list" on travis. Outputs of "conda list" and "pip freeze" are useful :-)
In line 133 script.newlines is checked , and there is a warning message for admin page created, if script.newlines has "wrong" value. In Python 3 we use the mode="r", newline=None to activate "universal line break mode" (https://docs.python.org/3.5/library/functions.html#open) , where in Python 2 there is the mode="rU" (https://docs.python.org/2.7/library/functions.html#open)
add a comment
create symlink for virtualenv env-folder to point to miniconda test-environment folder
use variable $TRAVIS_BUILD_DIR in .travis.yml
use $TRAVIS_BUILD_DIR to create an env as symbolic link beeing a sibling to praktomat folder and pointing to miniconda env
change order of two lines in .travis.yml
…running pip install -r requirements.txt)
…t SECRET_KEY. (see KITPraktomatTeam#250 (comment) ) this fix had been overwritten between October 2018 and July 2019 by merging KITmaster into this branch https://github.com/ifrh/Praktomat/tree/bugfix_small_typos . remove trailing whitespaces (as requested in May 2017 KITPraktomatTeam#268 (comment) and November 2021 KITPraktomatTeam#268 (comment) )
…t from German to English
ifrh
pushed a commit
to ifrh/Praktomat
that referenced
this pull request
Feb 8, 2022
The unit test code for praktomat.wsgi of commit 600e270 inside pullrequest KITPraktomatTeam#268 didn't "know" changes inside praktomat.wsgi of commit physikerwelt/Praktomat@3c697c0 inside pullrequest KITPraktomatTeam#279 This is a first step for fixing. Lets create a travis run to have a look on travis output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/settings/defaults.py (fixing typo to complete bugfix for class D, used for #250 , #250 (comment) )
src/settings/devel.py
src/settings/local.py
src/settings/test.py
Signed-off-by: Robert Hartmann (FB02, H-BRS) [email protected]