Make mat_number a string field #278
Closed
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For identity protection, some universities do not provide the actual mat_number via shibboleth. However, a unique mat_number of type integer is required. Using a string field is more flexible and should not yield to significant performance drops, since the mat_number is nominal data. Close KITPraktomatTeam#277
|
There is a merge conflict and I personally do no longer need this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For identity protection, some universities do not
provide the actual mat_number via shibboleth.
However, a unique mat_number of type integer is required.
Using a string field is more flexible and should not
yield to significant performance drops, since the
mat_number is nominal data.
Close #277