Hide binary files on the user interface #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How related are the changes to the discussion in feature request "List of submission files in the script checker" #181 ? |
This should not really be related to that discussion as my changes only affect what's being shown on the user interface. The discussion was about passing the list of submitted files to the script checker. |
|
I noticed that the Praktomat is also able to display images and PDFs. With a2985e4, these are also displayed again on the web interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binary files are submitted, they are currently also shown on the user interface with the content "Binary data". These binary files don't really need to be shown on the user interface. This makes finding the file you're searching for easier. If you need to access to binary files, you can still download the (whole) solution.
The only drawbacks with this approach are that you'll lose the ability to view what binary files were submitted. Also you can't just download a single binary file through the user interface anymore.
I'd prefer to have binary files hidden on the user interface instead of having the current situation. But let me know what you think about this. Maybe my approach would break something essential for someone else.