Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions workflow #349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update GitHub Actions workflow #349

wants to merge 2 commits into from

Conversation

hannesbraun
Copy link
Contributor

  • GitHub Actions will now also run tests for "taskstatistics".
  • This removes the comment about the missing gcj-jdk package (as it is no longer supported).

ifrh
ifrh approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ifrh ifrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-)

@ifrh
Copy link
Contributor

ifrh commented Jul 29, 2022

nice :-)

but tests failed with error message:

Traceback (most recent call last):
  File "/home/runner/work/Praktomat/Praktomat/src/hbrs_tests/test_admin_solutions_listview.py", line 41, in setUp
    self.assertEqual(response.status_code, 200)
AssertionError: 403 != 200

Fix for that problem see changes in pullrequest "Fix solution upload permissions for trainers" #348

@ifrh
Copy link
Contributor

ifrh commented Jul 29, 2022

@ratefuchs : I vote for merging.

ifrh pushed a commit to ifrh/Praktomat that referenced this pull request Aug 19, 2022
Update README.md: Insert information about new dependencies introduce…
13f2d44 
…d by merging "feature boxplot-taskstatistic" ( KITPraktomatTeam#345 )  .

Update README.md to give more information about installation steps : Fixes KITPraktomatTeam#250 .

Include change sets from KITPraktomatTeam#351 , KITPraktomatTeam#349 , KITPraktomatTeam#348
@ifrh ifrh mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifrh ifrh ifrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesbraun @ifrh