New Emailing Settings #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'attestationEmails' and 'uploadConfirmEmails' checkboxes added to the UserChangeForm.
to get the values of the 'attestationEmails' and 'uploadConfirmEmails' checkboxes of the UserChangeForm
'attestationEmails' and 'uploadConfirmEmails' have been added to the class User
to check if the user has selected the checkbox on the 'Change Account' page to confirm their willingness to receive an email fo each file upload ('False' by default)
to check if the user has selected the checkbox on the 'Change Account' page to confirm their willingness to receive attestation emails ('True' by default)
physikerwelt
suggested changes
Jan 23, 2023
src/accounts/views.py
Outdated
| #to get the value of the 'attestationEmails' checkbox. | ||
| attestationEmails = request.POST.get('attestationEmails') | ||
| #to change the values of the value of the checkbox to 'True' or 'False' | ||
| is_checked = bool(attestationEmails) |
There was a problem hiding this comment.
the comment should relate to line 73-88. I would guess
user = form.save(commit=False)
attestationEmails = form.cleaned_data['attestationEmails']
uploadConfirmEmails = form.cleaned_data['uploadConfirmEmails']
user.attestationEmails = attestationEmails
user.uploadConfirmEmails = uploadConfirmEmails
user.save()
does the job
There was a problem hiding this comment.
@Abdallah-Abouelatta I mean that only the lines quoted above should remain; the rest assigns a variable that is never used and can be deleted.
'attestation_emails' and 'upload_confirm_emails' checkboxes added to the UserChangeForm.
to get the values of the 'attestation_emails' and 'upload_confirm_emails' checkboxes of the UserChangeForm
'attestation_emails' and 'upload_confirm_emails' have been added to the class User
to check if the user has selected the checkbox on the 'Change Account' page to confirm their willingness to receive an email for each file upload ('False' by default)
to check if the user has selected the checkbox on the 'Change Account' page to confirm their willingness to receive attestation_emails ('True' by default)
The commit=False in the form.save(commit=False) is used to prevent the form from saving the object to the database immediately.
physikerwelt
suggested changes
Jan 27, 2023
'upload_confirm_emails' and 'attestation_emails' help text updated
A line that was previously too long has been broken into two separate lines for better readability.
A line that was previously too long has been broken into two separate lines for better readability.
physikerwelt
approved these changes
Jan 27, 2023
'upload_confirm_emails' and 'attestation_emails' help text updated
ifrh
suggested changes
Feb 4, 2023
There was a problem hiding this comment.
Perhaps change
Praktomat/src/solutions/views.py
Lines 167 to 168 in 49ab69f
to become like that:
if solution.author.email and User.attestation_emails:
message.send()
'and User.upload_confirm_emails' added to the if-statement of sending the upload confirmation email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing customizable email settings that allow users to select whether they wish to receive confirmation emails or not.
By default, the 'upload_confirm_emails' checkbox, which allows users to opt-in to receive email notifications for each file upload they make, is set to 'False'. However, the 'attestation_emails' checkbox, which allows users to opt-in to receive email notifications for each task attestation, is set to 'True' by default.