Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _reject_ongoing_promises with Promise.allSettled() #400

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

KSDaemon
Copy link
Owner

Description, Motivation and Context

Trying to fix unhandled promises during disconnection. Updated _reject_ongoing_promises() with Promise.allSettled() so all promises should be done (fulfilled or rejected).

This might fix #276

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no new functionality, only code improvements)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • Overall test coverage is not decreased.
  • All new and existing tests passed.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@KSDaemon KSDaemon merged commit dd871a1 into dev Jan 11, 2024
3 checks passed
@KSDaemon KSDaemon deleted the unhandled-promises branch January 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network connection interruption not detected
1 participant