-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RFCs docset #5156
Update RFCs docset #5156
Conversation
Test result: PASS 🟢
|
The link points to a file that does not exist (error 404). |
Sorry, fixed. |
The docset should be directly inside the archive (i.e. don't archive any enclosing folder). In your archive the docset is inside a I've remade the archive. If you can, please make sure to archive the docset directly on your next submission. Sorry for the inconvenience! |
Thank you. Absolutely. |
@Kapeli @pointlessone I used to be the maintainer of the RFC docset (see #2480), that was originally created by @willnorris The repo was not updated for a few years as the RFCs were migrated. Last month all the issues were cleared, and I started the process to get the docset ready for publishing. However, as I came here today, I noticed that last week the repo was replaced with a new one in this PR. How do you want to move forward in addressing the conflict? Any preference? |
Sure thing. Please give me until next week, this one I have limited connectivity. |
@Kapeli I uploaded the file, you can find it at https://storage.googleapis.com/rfcdash/RFCs.docset-v2.0.0.tgz Also referenced in https://github.com/willnorris/rfcdash/blob/master/RFCs.xml |
Hi @Kapeli, did you have the chance to take a look? Anything I can help with? |
Sorry, I missed your previous comment. The docsets seem to be very similar. The docset by @pointlessone has table of contents support for the RFCs that have the nicer page styling. See screenshots. Can you find any issues/shortcomings in the docset by @pointlessone? |
The docset file: RFCs.tgz.