Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RFCs docset #5156

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

pointlessone
Copy link
Contributor

The docset file: RFCs.tgz.

Copy link
Contributor

Test result: PASS 🟢


@Kapeli
Copy link
Owner

Kapeli commented Oct 1, 2024

The link points to a file that does not exist (error 404).

@pointlessone
Copy link
Contributor Author

Sorry, fixed.

@Kapeli Kapeli merged commit 7ed6b36 into Kapeli:master Oct 1, 2024
1 check passed
@Kapeli
Copy link
Owner

Kapeli commented Oct 1, 2024

The docset should be directly inside the archive (i.e. don't archive any enclosing folder). In your archive the docset is inside a dist folder.

I've remade the archive. If you can, please make sure to archive the docset directly on your next submission.

Sorry for the inconvenience!

Kapeli pushed a commit that referenced this pull request Oct 1, 2024
@pointlessone
Copy link
Contributor Author

Thank you. Absolutely.

@weppos
Copy link
Contributor

weppos commented Oct 10, 2024

@Kapeli @pointlessone I used to be the maintainer of the RFC docset (see #2480), that was originally created by @willnorris

The repo was not updated for a few years as the RFCs were migrated. Last month all the issues were cleared, and I started the process to get the docset ready for publishing.

However, as I came here today, I noticed that last week the repo was replaced with a new one in this PR.

How do you want to move forward in addressing the conflict? Any preference?

@Kapeli
Copy link
Owner

Kapeli commented Oct 10, 2024

@weppos Can you point me to a downloadable docset with @Tenzer's changes? My preference would be towards users getting the version of the docset with the least issues, so I'd start by comparing the 2 docsets. As I'm not familiar with this docset, any help / suggestions are greatly appreciated.

@weppos
Copy link
Contributor

weppos commented Oct 16, 2024

Sure thing. Please give me until next week, this one I have limited connectivity.

@weppos
Copy link
Contributor

weppos commented Oct 28, 2024

@weppos
Copy link
Contributor

weppos commented Nov 18, 2024

Hi @Kapeli, did you have the chance to take a look? Anything I can help with?

@Kapeli
Copy link
Owner

Kapeli commented Nov 18, 2024

Sorry, I missed your previous comment.

The docsets seem to be very similar.

The docset by @pointlessone has table of contents support for the RFCs that have the nicer page styling. See screenshots.

Screenshot 2024-11-18 at 12 17 39
Screenshot 2024-11-18 at 12 17 42

Can you find any issues/shortcomings in the docset by @pointlessone?

@pointlessone
Copy link
Contributor Author

My code is in Ruby so it's not exactly compatible with @weppos script. I'm fine if it's being used as reference (it's under Apache license) if @weppos is willing to maintain it and update the docset once in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants