Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38152 - Update lifecycle status to allow for empty support #11281

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fixes #38152 - Update lifecycle status to allow for empty support #11281

merged 1 commit into from
Jan 22, 2025

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Modified the model to show full support if full_support is blank, this will help when we have to go and add RHEL 11 in the future
  • Added a placeholder in for RHEL 10 so we can fill that in once we get the info from the BU
  • Wrote a unit test to test the empty value of full support.

Considerations taken when implementing this change?

  • Since we don't know the lifecycle status currently with RHEL 10 we modified the model to allow for empty values.

What are the testing steps for this pull request?

  • Checkout PR
  • Register a RHEL 10 host and check to see if the lifecycle status shows full support

@chris1984
Copy link
Member Author

With PR:
rhel101
rhel102

@lfu
Copy link
Member

lfu commented Jan 21, 2025

Before
unknown

After
full10
rl10

lfu
lfu approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chris1984 chris1984 merged commit 527df0a into Katello:master Jan 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfu lfu lfu approved these changes

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris1984 @lfu