Fixes #38150 - Switch log level of 2 harmless messages to debug level #11287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
reviewed
Jan 23, 2025
There was a problem hiding this comment.
This log + the logic that chooses the last version_href have been around for such a long time now that I don't think it's necessary to keep close track of them anymore.
What do you think about changing it to a debug log? Reducing the amount of normal logs is always helpful where possible.
If a user is having issues that are difficult to debug, I'd hope that enabling debug logging is a normal first step.
hao-yu
force-pushed
the
fix_warning_log_to_info_log
branch
from
fe1c3ab to
e5d031b
Compare
hao-yu
force-pushed
the
fix_warning_log_to_info_log
branch
from
e5d031b to
eda8a83
Compare
hao-yu
changed the title
|
Sure! sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.