Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38162 - Fix new repo form #11289

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fixes #38162 - Fix new repo form #11289

merged 1 commit into from
Jan 27, 2025

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jan 24, 2025

What are the changes introduced in this pull request?

Use an explicit closing </textarea> tag instead of a self-closing one.

Considerations taken when implementing this change?

Trial and error. Upon further googling learned that textarea requires both opening and closing tags:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#technical_summary

What are the testing steps for this pull request?

Go to repository> new page and see if the form renders correctly.

@jeremylenz
Copy link
Member

@sjha4 Looks like those transient test failures are back. Probably not related to the change here, but worth looking at..

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue!

APJ 👍

image

@sjha4 sjha4 merged commit 2647f49 into Katello:master Jan 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants