Refs #38162 - Fix invalid self-closing tags #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
repo_discovery_form
branch
from
2c40397 to
5df0556
Compare
sjha4
force-pushed
the
repo_discovery_form
branch
from
5df0556 to
f819414
Compare
sjha4
changed the title
jeremylenz
approved these changes
Jan 30, 2025
chris1984
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Add closing tag for
<select>, <div>, <span>and some bastion<date>tagsConsiderations taken when implementing this change?
Some browsers are smart and display invalid HTML correctly. Not all invalid self closing tags were causing issues for me on the UI in chrome. Others like select and textarea were.
What are the testing steps for this pull request?