Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use older runners to build binaries for compatibility #2069

Merged
merged 5 commits into from
Feb 18, 2025
Merged

ci: Use older runners to build binaries for compatibility #2069

merged 5 commits into from
Feb 18, 2025

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Feb 18, 2025

Description

  • Primarily for glibc version compatbility

nddeluca
nddeluca approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@nddeluca nddeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, generally prefer building on the oldest ubuntu LTS for glibc compatibility.

@drklee3 drklee3 marked this pull request as ready for review February 18, 2025 17:05
@drklee3 drklee3 merged commit 8fb2143 into release/v0.28.x Feb 18, 2025
10 of 11 checks passed
@drklee3 drklee3 deleted the dl-v0.28.0-older-libc branch February 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddeluca nddeluca nddeluca approved these changes

@rhuairahrighairidh rhuairahrighairidh Awaiting requested review from rhuairahrighairidh rhuairahrighairidh is a code owner

@karzak karzak Awaiting requested review from karzak karzak is a code owner

@pirtleshell pirtleshell Awaiting requested review from pirtleshell pirtleshell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drklee3 @nddeluca