Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Handle vshard error the same way as lua vshard router #77

Closed
nurzhan-saktaganov opened this issue Sep 18, 2024 · 1 comment · Fixed by #107
Closed

Handle vshard error the same way as lua vshard router #77

nurzhan-saktaganov opened this issue Sep 18, 2024 · 1 comment · Fixed by #107
Labels
enhancement New feature or request performance

Comments

@nurzhan-saktaganov
Copy link
Collaborator

How we handle now:

go-vshard-router/api.go

Lines 172 to 179 in e4e989d

if vshardErr.Name == "WRONG_BUCKET" ||
vshardErr.Name == "BUCKET_IS_LOCKED" ||
vshardErr.Name == "TRANSFER_IS_IN_PROGRESS" {
r.BucketReset(bucketID)
r.metrics().RetryOnCall("bucket_migrate")
continue
}

Reference how we should handle:
https://github.com/tarantool/vshard/blob/b6fdbe950a2e4557f05b83bd8b846b126ec3724e/vshard/router/init.lua#L662
@nurzhan-saktaganov nurzhan-saktaganov mentioned this issue Sep 18, 2024
Merged
nurzhan-saktaganov added a commit that referenced this issue Sep 26, 2024
@nurzhan-saktaganov
partially resolve issue #77
a3b2cab 
* RouterCallImpl: retry on BucketResolve error
* RouterCallImpl: do not retry on vshard error "TRANSFER_IS_IN_PROGRESS"
* RouterCallImpl: remove misleading RetryOnCall
nurzhan-saktaganov added a commit that referenced this issue Sep 27, 2024
@nurzhan-saktaganov
partially resolve issue #77
417deb1 
* RouterCallImpl: retry on BucketResolve error
* RouterCallImpl: do not retry on vshard error "TRANSFER_IS_IN_PROGRESS"
* RouterCallImpl: remove misleading RetryOnCall
nurzhan-saktaganov added a commit that referenced this issue Oct 1, 2024
@nurzhan-saktaganov
partially resolve issue #77
bd255f7 
* RouterCallImpl: retry on BucketResolve error
* RouterCallImpl: do not retry on vshard error "TRANSFER_IS_IN_PROGRESS"
* RouterCallImpl: remove misleading RetryOnCall
KaymeKaydex pushed a commit that referenced this issue Oct 1, 2024
@nurzhan-saktaganov
partially resolve issue #77 (#95)
09f9847 
* RouterCallImpl: retry on BucketResolve error
* RouterCallImpl: do not retry on vshard error "TRANSFER_IS_IN_PROGRESS"
* RouterCallImpl: remove misleading RetryOnCall
nurzhan-saktaganov added a commit that referenced this issue Nov 7, 2024
@nurzhan-saktaganov
resolve issue #77
e81ae86 
* handle vshard error the same way as lua vshard router.
@nurzhan-saktaganov
Copy link
Collaborator Author

Solution e81ae86

@nurzhan-saktaganov nurzhan-saktaganov added the future/nsaktaganov merged to future/nsaktaganov label Nov 7, 2024
nurzhan-saktaganov added a commit that referenced this issue Nov 8, 2024
@nurzhan-saktaganov
resolve issue #77
e60b83f 
* handle vshard error the same way as lua vshard router.
nurzhan-saktaganov added a commit that referenced this issue Nov 8, 2024
@nurzhan-saktaganov
resolve issue #77
1933cc6 
* handle vshard error the same way as lua vshard router.
nurzhan-saktaganov added a commit that referenced this issue Nov 18, 2024
@nurzhan-saktaganov
resolve issue #77
a8f96e4 
* handle vshard error the same way as lua vshard router.
@nurzhan-saktaganov nurzhan-saktaganov mentioned this issue Nov 18, 2024
Merged
1 task
nurzhan-saktaganov added a commit that referenced this issue Nov 18, 2024
@nurzhan-saktaganov
resolve issue #77
6052ea3 
* handle vshard error the same way as lua vshard router.
@nurzhan-saktaganov nurzhan-saktaganov linked a pull request Nov 18, 2024 that will close this issue
resolve issue #77 #107
Merged
1 task
nurzhan-saktaganov added a commit that referenced this issue Nov 26, 2024
@nurzhan-saktaganov
resolve issue #77
571a70c 
* handle vshard error the same way as lua vshard router.
nurzhan-saktaganov added a commit that referenced this issue Nov 26, 2024
@nurzhan-saktaganov
resolve issue #77
90cb297 
* handle vshard error the same way as lua vshard router.
KaymeKaydex pushed a commit that referenced this issue Dec 12, 2024
@nurzhan-saktaganov
resolve issue #77 (#107)
e025d0b
@nurzhan-saktaganov nurzhan-saktaganov removed the future/nsaktaganov merged to future/nsaktaganov label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve issue #77 KaymeKaydex/go-vshard-router
1 participant
@nurzhan-saktaganov