Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

resolve issue #77 #107

Merged
merged 1 commit into from
Dec 12, 2024
Merged

resolve issue #77 #107

merged 1 commit into from
Dec 12, 2024

Conversation

nurzhan-saktaganov
Copy link
Collaborator

  • handle vshard error the same way as lua vshard router.

What has been done? Why? What problem is being solved?
See issue #77

Related issues:

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_77 branch from a8f96e4 to 6052ea3 Compare November 18, 2024 20:45
@nurzhan-saktaganov nurzhan-saktaganov linked an issue Nov 18, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (097ac24) to head (90cb297).

Files with missing lines Patch % Lines
api.go 3.84% 24 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   69.49%   67.91%   -1.59%     
==========================================
  Files          13       13              
  Lines        1262     1284      +22     
==========================================
- Hits          877      872       -5     
- Misses        337      362      +25     
- Partials       48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurzhan-saktaganov nurzhan-saktaganov linked an issue Nov 20, 2024 that may be closed by this pull request
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_77 branch from 6052ea3 to 571a70c Compare November 26, 2024 16:01
* handle vshard error the same way as lua vshard router.
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_77 branch from 571a70c to 90cb297 Compare November 26, 2024 20:15
@KaymeKaydex KaymeKaydex merged commit e025d0b into master Dec 12, 2024
8 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_77 branch December 13, 2024 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended support of vshard errors Handle vshard error the same way as lua vshard router
3 participants