Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

partially resolve #100 (router_map_callrw) #114

Merged

Conversation

nurzhan-saktaganov
Copy link
Collaborator

@nurzhan-saktaganov nurzhan-saktaganov commented Dec 14, 2024

  • custom msgpackv5 decoders for router_map_callrw
  • new method 'RouterMapCallRW[T]'

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@nurzhan-saktaganov nurzhan-saktaganov changed the title partially resolve #100 (router_map_callrw) WIP: partially resolve #100 (router_map_callrw) Dec 14, 2024
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_router_map_call branch 2 times, most recently from 066b3a5 to 474d6c9 Compare December 14, 2024 18:56
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_bucket_stat branch 3 times, most recently from 87bd928 to 300523f Compare December 17, 2024 11:48
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_router_map_call branch from 474d6c9 to 80f3fb8 Compare December 17, 2024 16:33
@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from nsaktaganov_resolve_issue_100_for_bucket_stat to master December 17, 2024 16:33
@nurzhan-saktaganov nurzhan-saktaganov changed the title WIP: partially resolve #100 (router_map_callrw) partially resolve #100 (router_map_callrw) Dec 17, 2024
@nurzhan-saktaganov nurzhan-saktaganov marked this pull request as ready for review December 17, 2024 16:34
@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from master to nsaktaganov_resolve_issue_100_for_bucket_stat December 17, 2024 16:34
@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from nsaktaganov_resolve_issue_100_for_bucket_stat to master December 17, 2024 16:35
* custom msgpackv5 decoders for router_map_callrw
* new method 'RouterMapCallRW[T]'
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_router_map_call branch from 80f3fb8 to b086beb Compare December 17, 2024 16:35
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.29787% with 58 lines in your changes missing coverage. Please review.

Project coverage is 65.99%. Comparing base (0a8677f) to head (b086beb).

Files with missing lines Patch % Lines
api.go 38.29% 43 Missing and 15 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   67.33%   65.99%   -1.35%     
==========================================
  Files          13       13              
  Lines        1344     1391      +47     
==========================================
+ Hits          905      918      +13     
- Misses        377      405      +28     
- Partials       62       68       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaymeKaydex KaymeKaydex merged commit be1cfc4 into master Dec 18, 2024
8 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_100_for_router_map_call branch December 19, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a single error/response type with states and do decoding once
3 participants