Fix on header generator for c++11, regenerated products #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Conti
This was referenced Oct 29, 2024
bashbaug
requested changes
Oct 29, 2024
There was a problem hiding this comment.
I found this issue by testing these changes with the tests from #461, so the tests are working.
https://github.com/bashbaug/SPIRV-Headers/tree/add-utility-code-testing-test
bashbaug
approved these changes
Oct 29, 2024
|
Merging as discussed in the October 30th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework from #456 (new PR to unlock the CLA issue)