Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OpAsmTargetINTEL
instruction had an extra Result Type operand which is not specified in the extension https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_inline_assembly.asciidoc. This causes errors in tools relying on the headers.Small example of the failure:
Compile to
.spt
viallc
:The output contains something like
%12 = OpAsmTargetINTEL "spirv64-unknown-unknown"
, without any result type. Then, runningspirv-as foo.spt -o foo.spv
fails because return type is expected.Tagging @mmerecki who worked on the extension.