Remove "implementation note" #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only such "implementation note" in the specification, and it doesn't seem to add anything.
|
Agree! |
TApplencourt
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only such "implementation note" in the specification, and it doesn't seem to add anything.
I found this by accident, while trying to write some tooling to extract things from the SYCL specification. This "implementation note" doesn't have the same formatting as other non-normative notes, which broke my tooling. 😄
I originally intended to just fix the admonition block, but I think it would be better to remove this note entirely. Implementers can use SFINAE and/or concepts anywhere they like, and calling this out specifically in the device selector section doesn't seem valuable to me.