Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ignore): cleanup logger, add waitress clear util #1307

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jan 20, 2025

  • Remove lambda for error since it's always called anyway
  • Add ISO date to default logger (when setLogger not called, Z2M not concerned, but useful at least in testing ZH alone)
  • Add clear util fn to waitress (should avoid cascading errors in scenario where the waitress should no longer be expected to resolve, like a NCP crash)
    • TODO: need to figure out if should also reject every entry when called?
    • TODO: add calls wherever appropriate (separate PRs I think)

@Koenkk Koenkk merged commit dcf2592 into Koenkk:master Jan 23, 2025
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants