Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster.ts #1310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

fairecasoimeme
Copy link

Add new attribute to LixeeCluster

@Nerivec
Copy link
Collaborator

Nerivec commented Jan 25, 2025

This cluster should be moved to custom clusters directly in
https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/lixee.ts

@Koenkk
Copy link
Owner

Koenkk commented Jan 25, 2025

Please use the custom cluster API instead as @Nerivec mentioned, see https://github.com/Koenkk/zigbee-herdsman-converters/blob/284e8557ac7bde72429daee2f168f89e0050d4cd/src/devices/sonoff.ts#L41 for an example. You can update this PR to remove the cluster entirely.

@KipK
Copy link

KipK commented Feb 3, 2025

@Koenkk , can this be merged until a new external converter using modernExtend customCluster is made ?
It will take some time, seems to be a massive rewrite of lixee.js, there's nobody confident enough with zhc codebase yet to do it ( and lack of dev documentation )

The other PR on zhc related to this one has been merged and released in 2.1.0, but throw errors because this one is missing.

Thanks

@Nerivec
Copy link
Collaborator

Nerivec commented Feb 3, 2025

The issue is only to move the custom LiXee cluster to ZHC. There are plenty of examples in recent PRs. Since the goal is to remove custom clusters from the ZigBee spec, they are all being moved whenever the occasion presents.
Here's an example:
#1301
Koenkk/zigbee-herdsman-converters#8635 (ignoring new features also implemented by that PR)

@KipK
Copy link

KipK commented Feb 3, 2025

Ok I think I got it. Have to test first.

edit: @Nerivec, . I've spoke too fast, I won't be able to do that. There's too many thing I can't adapt, lost in Typescript. and this lixee.js is huge. I don't even know how to test correctly. ^^

@Koenkk
Copy link
Owner

Koenkk commented Feb 3, 2025

There's too many thing I can't adapt, lost in Typescript. and this lixee.js is huge. I don't even know how to test correctly. ^^

How can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants