-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tendermint): validators RPC #2310
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
9d0e6c8
to
ee20b9a
Compare
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Signed-off-by: onur-ozkan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank YOU :)
#[serde(flatten)] | ||
paging: PagingOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we have paging optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i meant having it optional as in the sense of accepting it being None
, and not applying a default.
so the pagination in this request:
komodo-defi-framework/mm2src/coins/tendermint/tendermint_coin.rs
Lines 2101 to 2107 in 61b1654
pagination: Some(PageRequest { | |
key: vec![], | |
offset: ((paging.page_number.get() - 1usize) * paging.limit) as u64, | |
limit: paging.limit as u64, | |
count_total: false, | |
reverse: false, | |
}), |
could follow accordingly.
it's OK though if u did this intentionally because we want the default behavior to paginate like so.
Signed-off-by: onur-ozkan <[email protected]>
9006269
to
96306cc
Compare
This is the initial implementation related to Tendermint staking feature on KDF. Remaining parts will be added gradually one by one similar to the
validators
RPC in this PR.e.g., RPC payload structure:
komodo-defi-framework/mm2src/mm2_test_helpers/src/for_tests.rs
Lines 3102 to 3112 in 4c63f6e
filter_by_status
can be set to one ofAll
,Bonded
andUnbonded
. Default isAll
.Explanation of
Bonded
andUnbonded
statuses:komodo-defi-framework/mm2src/coins/rpc_command/tendermint/staking.rs
Lines 12 to 18 in 43dbf48